From e78877783e30b8e58094364f15779b4cc220836a Mon Sep 17 00:00:00 2001 From: NepDisk Date: Sat, 17 May 2025 16:27:09 -0400 Subject: [PATCH] Fix buffer overflow in HWR_InitModels Idk who did this --- src/hardware/hw_md2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/hardware/hw_md2.c b/src/hardware/hw_md2.c index 172f9cf80..013b2fb39 100644 --- a/src/hardware/hw_md2.c +++ b/src/hardware/hw_md2.c @@ -494,7 +494,10 @@ void HWR_InitModels(void) size_t i; INT32 s; FILE *f; - char name[24], filename[32]; + char name[26], filename[32]; + // name[24] is used to check for names in the models.dat file that match with sprites or player skins + // sprite names are always 4 characters long, and names is for player skins can be up to 19 characters long + // PLAYERMODELPREFIX is 6 characters long float scale, offset; size_t prefixlen;