From b17601c1a5244e30499cf87b69fbeeada4d8c3a8 Mon Sep 17 00:00:00 2001 From: NepDisk Date: Sat, 13 Dec 2025 13:05:47 -0500 Subject: [PATCH] Clean up v1 UB for G_BuildMapName Lua --- src/lua_baselib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lua_baselib.c b/src/lua_baselib.c index dee59c079..ce361a40d 100644 --- a/src/lua_baselib.c +++ b/src/lua_baselib.c @@ -3330,9 +3330,9 @@ static int lib_gBuildMapName(lua_State *L) { INT32 map = Lcheckmapnumber(L, 1, "G_BuildMapName"); - if (lua_compatmode) // v1 has undefined behaviour if you return 0, who knew. + if (lua_compatmode && map == 0) // v1 has undefined behaviour if you return 0, who knew. { - map = map == 0 ? G_RandMap(G_TOLFlag(gametype), gamemap-1, 0, 0, NULL) + 1 : map; + map = G_NativeMapToKart(G_RandMap(G_TOLFlag(gametype), gamemap-1, 0, 0, NULL) + 1); } //HUDSAFE