incidentalstoat/blankart
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

R_ProjectSprite: fix overflow in sideways perspective clipping

Browse source 
Multiplications of perspective values can easily overflow
and flip sign bit at far distances. Instead, divide the
left operand.
This commit is contained in:
James R 2023-06-02 16:09:47 -07:00 committed by NepDisk
parent c3bae82317
commit 6019b8b96a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/r_things.cpp
View file

@ -2037,7 +2037,7 @@ static void R_ProjectSprite(mobj_t *thing)
tz2 = FixedMul(MINZ, this_scale); tz2 = FixedMul(MINZ, this_scale);
} }
if (tx2 < -(FixedMul(tz2, fovtan[viewssnum])<<2) || tx > FixedMul(tz, fovtan[viewssnum])<<2) // too far off the side? if ((tx2 / 4) < -(FixedMul(tz2, fovtan[viewssnum])) || (tx / 4) > FixedMul(tz, fovtan[viewssnum])) // too far off the side?
return; return;
yscale = FixedDiv(projectiony[viewssnum], tz); yscale = FixedDiv(projectiony[viewssnum], tz);